-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Chart: Allow setting annotations on Airflow pods &
Configmap
(#15238)
This PR adds a new field (`airflowConfigAnnotations`) that allows users to add `annotations` to the main `configmap.yaml` file. I ended up setting up a new testing file as I didn't find a file where this specifically fit, but if it should be moved elsewhere let me know. closes apache/airflow#13643 GitOrigin-RevId: 6d64cc54a6b7d1b22d0de89b5815035e21bfaf8c
- Loading branch information
1 parent
c0e2e2a
commit 7236eac
Showing
5 changed files
with
65 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
import unittest | ||
|
||
import jmespath | ||
|
||
from tests.helm_template_generator import render_chart | ||
|
||
|
||
class ConfigmapTest(unittest.TestCase): | ||
def test_single_annotation(self): | ||
docs = render_chart( | ||
values={ | ||
"airflowConfigAnnotations": {"key": "value"}, | ||
}, | ||
show_only=["templates/configmaps/configmap.yaml"], | ||
) | ||
|
||
annotations = jmespath.search("metadata.annotations", docs[0]) | ||
assert "value" == annotations.get("key") | ||
|
||
def test_multiple_annotations(self): | ||
docs = render_chart( | ||
values={ | ||
"airflowConfigAnnotations": {"key": "value", "key-two": "value-two"}, | ||
}, | ||
show_only=["templates/configmaps/configmap.yaml"], | ||
) | ||
|
||
annotations = jmespath.search("metadata.annotations", docs[0]) | ||
assert "value" == annotations.get("key") | ||
assert "value-two" == annotations.get("key-two") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters