Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy does not build on Windows as of preview.1 release #1390

Closed
enocom opened this issue Sep 8, 2022 · 0 comments · Fixed by #1400
Closed

Proxy does not build on Windows as of preview.1 release #1390

enocom opened this issue Sep 8, 2022 · 0 comments · Fixed by #1400
Assignees
@enocom
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@enocom
Copy link
Member

enocom commented Sep 8, 2022 •
edited
Loading

As of 6cf4d25, Windows support is broken.

This reached main because our CI doesn't fail on piped processes.

Related: #1396.
@enocom enocom added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 8, 2022
@enocom enocom mentioned this issue Sep 8, 2022
Merged
enocom added a commit that referenced this issue Sep 9, 2022
@enocom
fix: don't build FUSE paths for Windows
e92298d 
Fixes #1390.
@enocom enocom mentioned this issue Sep 9, 2022
Merged
enocom added a commit that referenced this issue Sep 12, 2022
@enocom
fix: don't build FUSE paths for Windows (#1400)
be2d14f 
Fixes #1390.
@mhoran mhoran mentioned this issue Sep 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enocom enocom

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't build FUSE paths for Windows GoogleCloudPlatform/cloud-sql-proxy
1 participant
@enocom