chore: convert XML in separate workflow step (#1396)

Co-authored-by: Eno Compton <enocom@google.com>
GoogleCloudPlatform · Sep 13, 2022 · 1b8d2ac · 1b8d2ac
1 parent be2d14f
commit 1b8d2ac
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -119,9 +119,15 @@ jobs:
           SQLSERVER_DB: '${{ steps.secrets.outputs.SQLSERVER_DB }}'
           TMPDIR: "/tmp"
           TMP: '${{ runner.temp }}'
+        # specifying bash shell ensures a failure in a piped process isn't lost by using `set -eo pipefail`
+        shell: bash
         run: |
-          go install github.com/jstemmer/go-junit-report/v2@latest
           go test -race -v ./... | tee test_results.txt
+
+      - name: Convert test output to XML
+        if: ${{ (github.event_name == 'schedule' || github.event_name == 'push') && always() }}
+        run: |
+          go install github.com/jstemmer/go-junit-report/v2@latest
           go-junit-report -in test_results.txt -set-exit-code -out integration_sponge_log.xml
 
       - name: FlakyBot (Linux)

diff --git a/.github/workflows/v1-periodic.yaml b/.github/workflows/v1-periodic.yaml
@@ -89,9 +89,15 @@ jobs:
           SQLSERVER_DB: '${{ steps.secrets.outputs.SQLSERVER_DB }}'
           TMPDIR: "/tmp"
           TMP: '${{ runner.temp }}'
+        # specifying bash shell ensures a failure in a piped process isn't lost by using `set -eo pipefail`
+        shell: bash
         run: |
-          go install github.com/jstemmer/go-junit-report/v2@latest
           go test -race -v ./... | tee test_results.txt
+
+      - name: Convert test output to XML
+        if: ${{ github.event_name == 'schedule' && always() }}
+        run: |
+          go install github.com/jstemmer/go-junit-report/v2@latest
           go-junit-report -in test_results.txt -set-exit-code -out v1periodic_sponge_log.xml
 
       - name: FlakyBot (Linux)