Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add missing javadoc comments to public methods. #2080

Merged
merged 1 commit into from
Oct 23, 2024
Merged

docs: Add missing javadoc comments to public methods. #2080

merged 1 commit into from
Oct 23, 2024

Conversation

hessjcg
Copy link
Collaborator

@hessjcg hessjcg commented Oct 23, 2024 •
edited
Loading

The checkstyle rules are becoming more strict. All public methods must now have javadoc.

@hessjcg hessjcg requested a review from a team as a code owner October 23, 2024 18:25
jackwotherspoon
jackwotherspoon approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we add a quick description to the PR explaining why we are adding this for future ref?

@hessjcg hessjcg enabled auto-merge (squash) October 23, 2024 18:28
@hessjcg hessjcg merged commit 00e0b1a into main Oct 23, 2024
17 checks passed
@hessjcg hessjcg deleted the fix-javadoc branch October 23, 2024 18:32
@release-please release-please bot mentioned this pull request Oct 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackwotherspoon jackwotherspoon jackwotherspoon approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hessjcg @jackwotherspoon