Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAST: improve GitHub workflow, stage 01 output fixes #966

Merged
merged 5 commits into from
Nov 11, 2022

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Nov 11, 2022

This PR

  • fixes errors in stage 01 outputs when output_files is set to null after having applied
  • improves the GitHub workflow to make it more resilient

Our GitHub workflow posts a comment to the PR with the result of the validation and plan steps, and for large plans it's fairly easy for the comment text to go over the maximum allowed limit of characters. This set of changes works around the issue by

  • posting the full plan output to the action status (visible in the action details) and preserving it in the action log
  • posting a smaller plan output to the comment where lines for the refresh part of the plan have been omitted

The action status is also posted for the apply phase that runs after merging, which does not post a comment to the PR.

Action status

image

Trimmed down plan in PR comment

image

@ludoo ludoo enabled auto-merge (squash) November 11, 2022 07:47
@ludoo ludoo merged commit eb27635 into master Nov 11, 2022
@ludoo ludoo deleted the ludo/fast-01-cicd-fixes branch November 11, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants