Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(project-factory): introduce additive iam bindings to project-fac… #932

Merged

Conversation

Malet
Copy link
Contributor

@Malet Malet commented Oct 31, 2022

…tory

@Malet Malet changed the title feat(project-factory): introduce additive iam bindings to project-fac… Draft: feat(project-factory): introduce additive iam bindings to project-fac… Oct 31, 2022
@Malet Malet force-pushed the feature/project-additive-iam branch from dcec8a9 to ef10970 Compare October 31, 2022 15:04
@Malet Malet force-pushed the feature/project-additive-iam branch from ef10970 to 78413f9 Compare October 31, 2022 15:09
@Malet
Copy link
Contributor Author

Malet commented Oct 31, 2022

This PR attempts to solve the issue of setting base IAM permissions for each group, for example:

group_iam_additive:
  gcp-foo-devops@bar.com:
    - roles/viewer
  gcp-foo-mlops@bar.com:
    - roles/viewer
  gcp-foo-data-engineers@bar.com:
    - roles/editor
  gcp-foo-platform-developers@bar.com:
    - roles/viewer

Whilst still allowing other teams with their own terraform repos (which are referring to a project-factory created project), to manage their own IAM permissions for service accounts.

@Malet Malet changed the title Draft: feat(project-factory): introduce additive iam bindings to project-fac… feat(project-factory): introduce additive iam bindings to project-fac… Oct 31, 2022
@ludoo
Copy link
Collaborator

ludoo commented Oct 31, 2022

Thanks for this!

@ludoo ludoo merged commit d7e0af7 into GoogleCloudPlatform:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants