Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #894

Closed

Conversation

nagendrasidgs
Copy link

@nagendrasidgs nagendrasidgs commented Oct 17, 2022

Added Examples to the org policies under list

Fixes #893

Added Examples to the Orgpolicies under List
@google-cla
Copy link

google-cla bot commented Oct 17, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@juliocc
Copy link
Collaborator

juliocc commented Oct 21, 2022

Thanks for helping us improve our docs. Can you sign the CLA and address the comments?

Thanks!

nagendrasidgs and others added 2 commits October 21, 2022 12:56
edited the Allow All section for "org policies" based on the feedback
@juliocc
Copy link
Collaborator

juliocc commented Oct 25, 2022

@nagendrasidgs can you sign the CLA?

@nagendrasidgs
Copy link
Author

@juliocc I did sign the CLA long ago. Please let me know how I can get this merged.

@juliocc
Copy link
Collaborator

juliocc commented Oct 28, 2022

Fixed with #930

@juliocc juliocc closed this Oct 28, 2022
@juliocc
Copy link
Collaborator

juliocc commented Oct 28, 2022

@nagendrasidgs we just finished a big refactor of org policies and as a result the project factory also changed. Thew new syntax is much more readable, please take a look and let us know if you still find it unclear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project factory doesnt support Allow all for org constraint policies at project level
2 participants