Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment redundant role in bootstrap stage, align IAM.md files, improve IAM tool #842

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Sep 28, 2022

This fixes #838 by commenting out the redundant role in stage 0.

It also adds support for duplicate folder names to the IAM dump tool, and updates IAM files for stages 0 and 1.

@ludoo ludoo added on:FAST on:tools New or changed tool labels Sep 28, 2022
@ludoo ludoo requested a review from juliocc September 28, 2022 22:03
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would it make sense to update FAST's IAM.md files from an on-merge hook?

@ludoo ludoo merged commit 4a1465a into master Sep 29, 2022
@ludoo ludoo deleted the ludo/issue-838 branch September 29, 2022 06:30
@ludoo
Copy link
Collaborator Author

ludoo commented Sep 29, 2022

LGTM. Would it make sense to update FAST's IAM.md files from an on-merge hook?

it would, but we would need a terraform state...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on:FAST on:tools New or changed tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlapping GCP organization domain IAM (bootstrap)
2 participants