Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor net-address module for 1.3 #840

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Refactor net-address module for 1.3 #840

merged 1 commit into from
Sep 28, 2022

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Sep 28, 2022

No description provided.

@ludoo ludoo requested a review from juliocc September 28, 2022 11:43
@ludoo ludoo changed the title Refactor net-address modules for 1.3 Refactor net-address module for 1.3 Sep 28, 2022
sruffilli
sruffilli approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@sruffilli sruffilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we might consider in the future unifying all types of supported addresses into a single attribute. Or not :)

@ludoo ludoo merged commit fcf71b9 into master Sep 28, 2022
@ludoo ludoo deleted the ludo/module-addresses-1.3 branch September 28, 2022 12:10
@ludoo ludoo added the incompatible change Pull request that breaks compatibility with previous version label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sruffilli sruffilli sruffilli approved these changes

@juliocc juliocc Awaiting requested review from juliocc

Assignees
No one assigned
Labels
incompatible change Pull request that breaks compatibility with previous version on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ludoo @sruffilli