instance_termination_action must be set for compute-vm spot instances #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sruffilli
changed the title
|
Can you also address #777 here? |
ludoo
reviewed
Aug 20, 2022
ludoo
reviewed
Aug 20, 2022
ludoo
approved these changes
Aug 20, 2022
ludoo
added
on:modules
incompatible change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google_compute_instanceandgoogle_compute_instance_templatehavingprovisioning_model = SPOTmust havescheduling.instance_termination_actionset to eitherSTOPorDELETE.Even if the field is optional, not having it set triggers the following behaviors:
google_compute_instance-> state flappinggoogle_compute_instance_template-> state flapping triggering an error, as update is not supported.This PR sets
scheduling.instance_termination_action=STOP(which is the default).#777 tracks the ability to optionally customize instance_termination_action