Set cluster id output to sensitive in GKE module #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
reviewed
Jul 25, 2022
|
No, there is no need for it to be sensitive, it is just an id, so i removed the sensitive flag. |
ludoo
approved these changes
Jul 25, 2022
ludoo
changed the title
|
No, there is no need for it to be sensitive, it is just an id, so i removed
the sensitive flag.
…On Mon, Jul 25, 2022 at 3:00 PM Ludovico Magnocavallo < ***@***.***> wrote:
***@***.**** commented on this pull request.
why does this need to be sensitive?
—
Reply to this email directly, view it on GitHub
<#756 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AESWBEPQ5SMIHNLCA2NB3CLVV2FVHANCNFSM54SGBHIA>
.
You are receiving this because you authored the thread.Message ID:
<GoogleCloudPlatform/cloud-foundation-fabric/pull/756/review/1049427049@
github.com>
--
Miren Esnaola | Google Cloud Professional Services | ***@***.***
| office:
+34 917 48 66 47
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.