Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multi region cloud SQL documentation #746

Merged
merged 14 commits into from
Jul 20, 2022
Merged

Update multi region cloud SQL documentation #746

merged 14 commits into from
Jul 20, 2022

Conversation

bensadikgoogle
Copy link
Collaborator

@bensadikgoogle bensadikgoogle commented Jul 20, 2022

Update documentation for the "Cloud SQL multi-regional" architecture example with a detailed tutorial

@ludoo
Copy link
Collaborator

ludoo commented Jul 20, 2022

Thanks for this! Can you provide a description of what it does?

@bensadikgoogle
Copy link
Collaborator Author

updated the description !! 👍

Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you fix linting this is good to go, many thanks! To fix linting you need to run our tfdoc tool against the directory, it will generate a new variable table. Those are not supposed to be edited by hand, and it's why the test fails. Instructions are in our top-level contributing doc.

@ludoo ludoo merged commit a5536f8 into GoogleCloudPlatform:master Jul 20, 2022
@ludoo ludoo changed the title Update multi region cloud SQL markdown file Update multi region cloud SQL documentation Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants