Update Readme.md: gcs to bq + cloud armor / glb #743
Conversation
|
Can you make sure linting checks pass? The instructions are in our contributing guide in the top-level folder. |
|
Both the old and the new diagram are missing the cloud nat instances in two regions |
|
@apichick thanks I'll look into it |
|
@apichick in what architecture do you think we should add Cloud NAT ? I'm not seeing any mention of NAT in the written explanation. As I haven't worked on them but happy to discuss this if you have time |
|
@ludoo @apichick do you have an idea on why this check fails? |
|
I just sent a PR that should fix it. :) |
|
@apichick thanks for the review I removed/changed the ambiguous sentences as you requested. Let me know if this works for you |
|
GLB + armor changes look good to me @lcaggio dud you have the change to look at the gcs and bq changes? |
|
I think it is not related to your PR, one I just made fails for the same
reason.
…On Mon, Jul 25, 2022 at 3:24 PM bensadikgoogle ***@***.***> wrote:
@ludoo <https://github.com/ludoo> @apichick <https://github.com/apichick>
do you have an idea on why this check fails?
Here are the content that generates failures (2 failed, 156 passed)
I'm not 100% sure I understand what this test step performs
FAILED tests/doc_examples/test_plan.py::test_example[net-glb:HTTPS And SSL Certificates 3]
FAILED tests/doc_examples/test_plan.py::test_example[net-ilb-l7:HTTPS And SSL Certificates 2]
—
Reply to this email directly, view it on GitHub
<#743 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AESWBEO22KTU7XIZ4CUXICDVV2IRFANCNFSM5334OTZA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
--
Miren Esnaola | Google Cloud Professional Services | ***@***.***
| office:
+34 917 48 66 47
|
No description provided.