Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAST: configuration switches for features #703

Merged
merged 8 commits into from
Jun 28, 2022
Merged

FAST: configuration switches for features #703

merged 8 commits into from
Jun 28, 2022

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Jun 27, 2022

This shows how I would approach the topic of "configuration switches" we discussed last week:

  • a simple object variable with one bool type member for each feature
  • declared in stage 00 and set by default to enable all features
  • stored in globals like other user-configurable stage 00 variables that carry over to other stages

It looks pretty simple and does not complicate code readability.

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@sruffilli
Copy link
Collaborator

I'm aware this is just a stab - couple of observations:

  • Disabling branches has impact also on later stages (definitely networking)
  • I would want to see e2e tests with disabled features

Nice one.

@ludoo
Copy link
Collaborator Author

ludoo commented Jun 27, 2022

  • Disabling branches has impact also on later stages (definitely networking)

Yep, the config is trickled down through all stages, so each stage should comply with it for it's own part.

  • I would want to see e2e tests with disabled features

Yep, we need to great point.

@ludoo ludoo changed the title Example implementation of FAST configuration switches for features FAST: configuration switches for features Jun 28, 2022
@ludoo ludoo marked this pull request as ready for review June 28, 2022 12:06
@ludoo ludoo requested review from juliocc and sruffilli June 28, 2022 14:47
@ludoo ludoo merged commit 66c4fff into master Jun 28, 2022
@ludoo ludoo deleted the ludo/fast-config branch June 28, 2022 15:33
@ludoo ludoo added the on:FAST label Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants