Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-vpc - add missing iam properties to factory_subnets #1153

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

jamesdalf
Copy link
Contributor

Module: net-vpc
When creating subnets via a data folder input, the properties iam_groups, iam_users, and iam_service_accounts are ignored. These are required in order to bind "roles/compute.networkUser"

The default value in the try function is an empty list as formatting in _factory_subnets_iam cannot be performed on a null value.

@google-cla
Copy link

google-cla bot commented Feb 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jamesdalf
Copy link
Contributor Author

Hi, regarding the example tests. I believe the only failing test occurs because the extra resource 'google_compute_subnetwork_iam_binding' was ignored in the previous module and therefore not accounted for in the tests. Now that the iam properties are there, an extra resource would be created.

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for the PR

I fixed the tests for you.

@juliocc juliocc merged commit fed928b into GoogleCloudPlatform:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants