Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for service-mesh example in gke-hub #1144

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Fixes for service-mesh example in gke-hub #1144

merged 1 commit into from
Feb 9, 2023

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Feb 9, 2023

  • Fix missing subnets and duplicate service account names for nodepools
  • add fix for missing IAM role for fleet service account
  • enable dataplane_v2 and workload_identity as they are required for Service Mesh

ludoo
ludoo approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue what you are doing but I trust you :)

@wiktorn wiktorn merged commit fab2ad0 into GoogleCloudPlatform:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktorn @ludoo