Allow configuring regions from tfvars in FAST networking stages #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sruffilli
approved these changes
Feb 7, 2023
juliocc
reviewed
Feb 7, 2023
|
needs actual testing for vpn/nva/separated |
juliocc
approved these changes
Feb 8, 2023
ludoo
added
the
incompatible change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has bugged me for a long time: if I want to change regions in our networking stages, I need to edit the code in a lot of places, including module names and references (
module.landing-to-onprem-ew1-vpnetc.).The
region_trigramsvariable is also pretty evil, and would wreak havoc with subnets added via factory for regions not accounted for in variables.So this PR proposes a way to abstract the region definition in variables via
primaryandsecondaryregions, and generating region abbreviations on the fly for all regions present in subnets.It only does so for the peering stage to validate the concept, it will of course be fairly easy to roll this out to the other network stages. I ran the stage against the current one and plan did not show any difference apart from the change in module names via
movedblocks.As an aside, I also think that L7 ILB subnets and PSA should come via factory, to minimize the variable surface and offer (almost) full configuration via delcarative files. I plan to tackle this once the regions thing is sorted.