Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster replicas to Bigtable module. #1075

Merged
merged 4 commits into from
Dec 30, 2022

Conversation

iht
Copy link
Member

@iht iht commented Dec 28, 2022

This adds the possiblity to define several clusters in a Bigtable instance, which enables replication in Bigtable.

Some of the configurations options are moved inside a map that defines the properties of each cluster.

These changes alter the interface of the module, so any previous code using this module will have to adapt to the new options interface.

This adds the possiblity to define several clusters in a Bigtable instance,
which enables replication in Bigtable.

Some of the configurations options are moved inside a `map` that defines the
properties of each cluster.

These changes alter the interface of the module, so any previous code using this
module will have to adapt to the new options interface.
@iht iht added incompatible change Pull request that breaks compatibility with previous version on:modules labels Dec 28, 2022
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment on the local type, other than that it's the usual great PR, thanks Israel

@iht iht enabled auto-merge December 30, 2022 10:28
@iht iht merged commit 0380c10 into GoogleCloudPlatform:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible change Pull request that breaks compatibility with previous version on:modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants