Allow tables with several column families in Bigtable #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes GoogleCloudPlatform#1064 by allowing to add more than one column family. Split keys are also now optional, and there is no possibility to set defaults for all tables (since keys and column families are related to the data and schema for each table, it is difficult that several tables share the same values). Also, declaring a table with no split keys nor column families requires initializing the table to an empty map, instead of using null.
ludoo
reviewed
Dec 22, 2022
ludoo
approved these changes
Dec 22, 2022
ludoo
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A table in Bigtable can have more than one column family (or none), and
split_keysis optional forgoogle_bigtable_tableresources.This PR fixes #1064. It lets the user specify 0 or more column families for each table, and makes
split_keysan optional parameter for each declared table.Because column families are schema properties of a Bigtable table and
split_keysare related to the actual values stored in a table, I don't think it makes sense to speak of default settings for those properties, and I have removed that option from this module. Now users should specify (or not)column_familiesandsplit_keysfor each one of the declared tables.The default value for a table with no additional options was
null. I have changed that to an empty map{}so the default values of the correspondingoptionalparameters are used.