Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector: refresh token if needed before metadata exchange. #347

Closed
wants to merge 1 commit into from

Conversation

xjuan
Copy link

@xjuan xjuan commented Jul 17, 2024

Fix issue #346 "Invalid token in metadata exchange"

@xjuan xjuan requested a review from a team as a code owner July 17, 2024 14:24
Copy link

google-cla bot commented Jul 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@enocom
Copy link
Member

enocom commented Jul 17, 2024

Thanks for the PR @xjuan. Before we can look at this, we need you to sign the CLA.

See here for details: https://github.com/GoogleCloudPlatform/alloydb-python-connector/pull/347/checks?check_run_id=27567309191

@xjuan
Copy link
Author

xjuan commented Jul 18, 2024

Hi the CLA was submitted my the CTO, not sure if it should refresh automatically or not

@enocom
Copy link
Member

enocom commented Jul 19, 2024

If look at https://github.com/GoogleCloudPlatform/alloydb-python-connector/pull/347/checks?check_run_id=27633672198, it will let you re-run the scan. I think right now the commit has a personal and a company email which is causing it to still fail.

@enocom
Copy link
Member

enocom commented Jul 22, 2024

We'd like to get this bug fixed and in a release ASAP. Thanks again for the issue @xjuan!

@enocom
Copy link
Member

enocom commented Jul 22, 2024

Replaced by #351.

@enocom enocom closed this Jul 22, 2024
@xjuan
Copy link
Author

xjuan commented Jul 26, 2024

hi, sorry I was in a conference, thanks for taking care of this.

@enocom
Copy link
Member

enocom commented Jul 26, 2024

No problem. Thanks for the issue. On further digging we found the root cause (this was just a symptom): #357.

@enocom
Copy link
Member

enocom commented Jul 26, 2024

That's also been fixed in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants