Added tests for different filter types Binary and Numeric #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
halio-g
commented
Oct 31, 2023
halio-g
commented
- Added validation to skip pushdown for Array type columns.
- Added unit test for Datatype Binary and Decimal.
odeke-em
approved these changes
Oct 31, 2023
spark-3.1-spanner-lib/src/main/java/com/google/cloud/spark/spanner/SparkFilterUtils.java
Outdated
Show resolved
Hide resolved
We only store the json and jsonb in the col_type, so we don't need to modify the schema information query. We need the metadata when converting the Spark SQL to GoogleSql. |
…o be suffixed with -0 to specify it's utc time in FilterUtil.
…ll check in predicates for array and normal data type. 3. Numeric column out of scope. 4. Test the inf, nan in the filter.
…Spanner exception otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.