Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced library size, fixed shading #109

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

davidrabinowitz
Copy link
Member

No description provided.

@davidrabinowitz davidrabinowitz self-assigned this Oct 9, 2023
@davidrabinowitz
Copy link
Member Author

/gcbrun

Copy link
Collaborator

@halio-g halio-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change David. Mostly looks good to me. Just have a comment on the junit

<scope>runtime</scope>
</dependency>

<dependency>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the test pass if we remove the junit dependency ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JUnit is added by the parent

@davidrabinowitz davidrabinowitz merged commit 44941d7 into GoogleCloudDataproc:main Oct 9, 2023
@davidrabinowitz davidrabinowitz deleted the shading branch October 9, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants