Update the Wabt version to the latest release #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roll forward the Wabt version to include the SIMD opcode renumbering changes as reflected in the tracking issue - WebAssembly/simd#216.
|
Ah, this would close #22! Thanks @dtig! @RReverser, anything else that needs to be done? |
surma
approved these changes
May 12, 2020
|
No, wait, actually... That line is wrong. We don't use binary anymore. |
RReverser
suggested changes
May 12, 2020
|
Looks like https://github.com/AssemblyScript/wabt.js still hasn't updated their nightly (which is weird, because it should be done automatically per the description). |
|
I've raised an issue with wabt.js here: AssemblyScript/wabt.js#13 Made a PR to remove build.sh to avoid confusion here: #25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll forward the Wabt version to include the SIMD opcode renumbering changes as reflected in the tracking issue - WebAssembly/simd#216.