Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass handle in filePickerShown callback #116

Merged

Conversation

tclangv
Copy link
Contributor

@tclangv tclangv commented Jun 22, 2022

I need the name of the file handle, which the user has entered, before the file writing is complete.
Currently the handle is only returned upon completion, but it is actually available right after the file picker was shown.

Even though I don't need the whole handle, only the file name, I return the handle in case it might be useful to others at some point.

Copy link
Member

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@tomayac tomayac merged commit c69c6ab into GoogleChromeLabs:main Jun 22, 2022
@tomayac
Copy link
Member

tomayac commented Jun 22, 2022

Released as v0.30.1. Thanks!

@tclangv tclangv deleted the pass_handle_in_filePickerShown branch June 22, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants