-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not crash if non-prefixed AudioContext isn't available #11
Conversation
Safari 11.x only has prefixed `webAudioContext`: without this patch the polyfill crashes.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it. |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small change - I can make it if you want, or you can!
@@ -47,7 +47,7 @@ if (typeof AudioWorkletNode !== 'function') { | |||
return scriptProcessor; | |||
}; | |||
|
|||
Object.defineProperty(AudioContext.prototype, 'audioWorklet', { | |||
Object.defineProperty((window.AudioContext||webkitAudioContext).prototype, 'audioWorklet', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will crash if neither are defined. Need to do:
(self.AudioContext || self.webkitAudioContext)
FWIW I usually recommend "polyfilling" AudioContext in Safari globally: if (!window.AudioContext && window.webkitAudioContext) = window.AudioContext = window.webkitAudioContext; |
Shipped in 1.1.1! Cheers. |
My app now work perfectly in Safari & Firefox! |
Safari 11.x only has prefixed
webAudioContext
: without this patch the polyfill crashes.Fixes #9