Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'currentTime' and 'sampleRate' remain 0 in simulated AudioWorkletGlobalScope #7

Closed
JohnWeisz opened this issue Aug 26, 2018 · 2 comments
Closed

'currentTime' and 'sampleRate' remain 0 in simulated AudioWorkletGlobalScope #7

JohnWeisz opened this issue Aug 26, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@JohnWeisz
Copy link
Contributor

These lines don't do anything, because the fake AudioContext properties are copied into global scope once on initialization.
@developit
Copy link
Collaborator

Ah - good catch, I should have exempted them to avoid that shadowing.

developit added a commit that referenced this issue Aug 28, 2018
@developit
Fix currentTime and sampleRate shadowing bug (#7)
eb0840c
@developit
Copy link
Collaborator

Thanks John - it looks like I'd only tested property access, which was working (self.currentTime, old lint habits). This issue is now fixed in 1.1.0.

@developit developit added the bug Something isn't working label Aug 28, 2018
@JohnWeisz JohnWeisz mentioned this issue Sep 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@developit @JohnWeisz