Strips the hash from a URL in a couple of places #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyosmani
added
the
Chillin'
|
@wibblymat hi hi |
gauntface
suggested changes
Jun 27, 2017
| @@ -305,6 +305,9 @@ class WorkboxSW { | |||
|
|
|||
| const route = new Route({ | |||
| match: ({url}) => { | |||
| // See https://github.com/GoogleChrome/workbox/issues/488 | |||
There was a problem hiding this comment.
Can you put the actual problem description here?
|
PTAL. |
gauntface
approved these changes
Jun 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
The discussion in #488 talked about putting as much of the logic as possible inside reusable plugins; some of the logic that was changed in this PR is inside the
CacheExpirationplugin.However, there's no concept of plugins for routing (only for request handlers), and we needed to adjust the routing logic for precached URLs inside of
workbox-sw. So that part is just done inline.Fixes #488