Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. webpack changes #2683

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Misc. webpack changes #2683

merged 1 commit into from
Nov 30, 2020

Conversation

jeffposnick
Copy link
Contributor

R: @Snugug @philipwalton

Fixes #2681, fixes #2674

These are some small, final webpack-related changes I'd like to get in before the final Workbox v6 release.

  • Bump the minimum required version of webpack v5 to v5.9.0, as that includes some changes that is needed for Workbox v6.
  • Use Error objects when adding to the compilation warnings instead of strings.
  • Treat multiple instances of self.__WB_MANIFEST in the swSrc as a compilation error, matching the workbox-build behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants