Use importWorkboxFrom instead of importWorkboxFromCDN #1137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @gauntface
This is part of the work for #933.
I wanted to break it into multiple PRs, which this one just covering the removal of
importWorkboxFromCDN
and addition ofimportWorkboxFrom
.I'll put together a separate PR to support
importWorkboxFrom
in theworkbox-webpack-plugin
, since that requires introducingjoi
as a dependency in the webpack package, and will end up being a fair chunk of independent work to modify how we deal with options there.