Skip to content

Commit

Permalink
undo lazy attribute
Browse files Browse the repository at this point in the history
  • Loading branch information
jcscottiii committed Jan 2, 2025
1 parent 324eea2 commit ad87403
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
7 changes: 3 additions & 4 deletions frontend/src/static/js/components/webstatus-sidebar-menu.ts
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ export class WebstatusSidebarMenu extends LitElement {
const bookmarkIcon = isQueryActive ? 'bookmark-star' : 'bookmark';

return html`
<sl-tree-item id=${bookmarkId} ?selected=${isQueryActive} lazy>
<sl-tree-item id=${bookmarkId} ?selected=${isQueryActive}>
<a class="bookmark-link" href="${bookmarkUrl}">
<sl-icon name="${bookmarkIcon}"></sl-icon> ${bookmark.name}
</a>
Expand All @@ -270,7 +270,6 @@ export class WebstatusSidebarMenu extends LitElement {
<sl-tree-item
id="${NavigationItemKey.FEATURES}"
.expanded=${this.isFeaturesDropdownExpanded}
lazy
>
<sl-icon name="menu-button"></sl-icon>
<a
Expand All @@ -289,7 +288,7 @@ export class WebstatusSidebarMenu extends LitElement {
<sl-divider aria-hidden="true"></sl-divider>
<sl-tree-item class="report-issue-item" lazy>
<sl-tree-item class="report-issue-item">
<sl-icon name="github"></sl-icon>
<a
class="report-issue-link"
Expand All @@ -299,7 +298,7 @@ export class WebstatusSidebarMenu extends LitElement {
>
</sl-tree-item>
<sl-tree-item class="about-item" lazy>
<sl-tree-item class="about-item">
<sl-icon name="info-circle"></sl-icon>
<a class="about-link" href="${ABOUT_PAGE_LINK}" target="_blank"
>About</a
Expand Down
7 changes: 6 additions & 1 deletion frontend/web-test-runner.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@
* limitations under the License.
*/

const filteredLogs = ['Running in dev mode', 'Lit is in dev mode'];
const filteredLogs = [
'Running in dev mode',
'Lit is in dev mode',
// sl-tree-item has its own reactivity that we cannot control. Ignore for now.
'Element sl-tree-item scheduled an update',
];

export default /** @type {import("@web/test-runner").TestRunnerConfig} */ ({
concurrency: 10,
Expand Down

0 comments on commit ad87403

Please sign in to comment.