misc: re-enable pubads after esm migration #14241
Conversation
package.json
Outdated
| @@ -159,7 +159,7 @@ | |||
| "jsdom": "^12.2.0", | |||
| "jsonld": "^5.2.0", | |||
| "jsonlint-mod": "^1.7.6", | |||
| "lighthouse-plugin-publisher-ads": "^1.5.6", | |||
| "lighthouse-plugin-publisher-ads": "https://gitpkg.now.sh/connorjclark/publisher-ads-lighthouse-plugin/lighthouse-plugin-publisher-ads?esm", | |||
There was a problem hiding this comment.
does this lock to a commit / tag? or what happens when you add more commits that aren't ready for integration?
|
Wut?
|
Somehow the permissions of that file changed locally... |
connorjclark
requested review from
adamraine
and removed request for
brendankenny
connorjclark
assigned connorjclark and adamraine and unassigned brendankenny and connorjclark
connorjclark
changed the title
|
These changes landed in their main branch, so we can land this now and get pubads back into our CI. |
|
We may want to sit on this for awhile, until more |
| @@ -20,7 +20,7 @@ cd /tmp/lighthouse-local-test | |||
|
|
|||
| npm init -y | |||
| npm install "$LH_ROOT/lighthouse-$VERSION.tgz" | |||
| npm install lighthouse-plugin-publisher-ads | |||
There was a problem hiding this comment.
Could we add a TODO(esmodules) here for when this is out of beta. I feel like we'll forget.
| @@ -6128,7 +6128,6 @@ query-string@^4.1.0: | |||
|
|
|||
| quibble@^0.6.7, quibble@connorjclark/quibble#mod-cache: | |||
| version "0.6.14" | |||
| uid "68d53b087d4c9117cc86c7e5f19e7953a219582b" | |||
There was a problem hiding this comment.
This was an intentional update from your quibble stuff right?
There was a problem hiding this comment.
making any change to the deps results in this delta even on master, so best to just ignore i guess.
This PR converted to ESM: googleads/publisher-ads-lighthouse-plugin#354