-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explanation of old CSS flexbox + advice #1710
Comments
I think @gauntface hates users. "display: -ms-flexbox" is like 20 bytes to save :p In all seriousness, we flag prefixes so users know they're sending more CSS down the wire than what they need. The new flexbox has 97% support, including IE11. What's interesting thought is that you're using "'not ie <= 11'", and the This is also a good example of where caniuse data (#1453) would help users make a decision on whether to "ignore" the audit or not. |
Agree with everything you're saying, but if using a widely used and accepted tool means I can't pass Lighthouse, it feels like there is an extra step of either working with tool vendors to see if there is anything that can be done to fix on their side, or the audit be changed to account for the reality of web development. |
The end result of the autoprefixer config is that it should be:
@kaycebasques do you think it would be worth calling this out in the docs on Web Fundamentals? |
Posting here to help anyone that might come from Angular: Adding the following the package.json file will indeed fix this error.
|
@ebidel Discouraging the use of old flexbox reflects potentially on that 10% user base of the web. You could explain instead they are potentially sending more CSS down the wire than they may not need, according to the geographic location of their main user base. But saying the 2009 spec of Flexbox is deprecated and should avoided reads as ill advice for devs in India, China or others countries. And let's not forget that deliberately ignoring 0.1% of worldwide web users means 3.5 million people. |
thanks @hexalys I'm adding a "caution" callout to the doc with a link to your comment |
The Autoprefixer thing is mentioned in the PR above |
Just got flagged for 'Avoids old CSS flexbox' in the latest lighthouse.
One thing that is unclear from the explanation in the '? > Learn More' link is that it's looking for both "display: box" and "display: flexbox".
With that, how should developers using auto-prefixer support this rule? I'm not getting any entries for
display: box
but I am getting an error ondisplay: -ms-flexbox
.Looking at my browser support list for autoprefixer, I'm not sure how I can prevent this from being printed out, I tried:
But it doesn't stop it from being added. What's the right advice for this?
The text was updated successfully, but these errors were encountered: