-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server): add a health check route before auth #531
Conversation
thanks @ddunkin! where does
All come to mind as options, but if the |
|
cool, works for me then! a test that this new endpoint works would be much appreciated and we're good to merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Google Kubernetes Engine default ingress requires a health check route that returns a 200 response. If basic authentication is enabled, there is no route that can be used for a health check. This PR adds a
/healthz
route before the auth middleware to be used for health checks.