Fix download auto-pausing when network is cut #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -226,7 +226,11 @@ export default class DownloadManager { | |||
| */ | |||
| forcePause() { | |||
| this.pause(); | |||
| this.internal.videoDownloader.downloading = false; | |||
|
|
|||
| if (document) { | |||
There was a problem hiding this comment.
When is document falsy?
There was a problem hiding this comment.
@beaufortfrancois In the service worker context, where DownloadManager is also used to interact with the Background Fetch API events.
|
Bug found: #183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
DownloadManagerno longer has direct access to an associatedvideoDownloaderinstance after the changes requires to support the Background Fetch API.We now use a custom event to signal a pause intent and when we're in a
documentcontext, we allow theVideoDownloaderRegistryinstance to listen to these events and to direct them to the appropriatevideoDownloaderinstances allowing them to change their UI to display a paused state.Fixes #176