-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds test coverage for alpine linux #68
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
I originally committed to his fork, and ultimately wanted him to integrate and continue testing in his environment (As there may have been some bugs with the travis build), to ultimately merge into your repo. |
Spent some time digging into this one. Once I saw what tests were failing it became somewhat obvious that there was an issue with any of the tests that actually launch chrome:
But this was not enough to identify the root issue. By connecting to the docker image and overwriting the entry point to
So issue #25 strikes again! |
After turning the flag off, and giving chrome enough time to launch we are greeted by another fun error message
This seems to be due to the fact that I did not run the container as --privileged Once I added that flag to my docker command I was presented with this remaining error Which looks to be due to the fact that I am running the docker image on my mac and am not correctly forwarding my X11 server into my docker image execution |
Alright spent a few more hours on this, still unable to run this locally, and it is running partially on travis If any feels like picking this back up, please ping this PR and you can have at it. Thanks |
(redoing this PR against the real upstream)
text from @danbopes:
I've gone ahead and added some alpine test coverage using travis-ci and docker to build an alpine image and test the run in there. It may need some tweaks/changes (chromium appears to be in /usr/lib/chrome, but it may not be functionality correctly), but this should be a good start to determine if this is working correctly.
See the following docker test:
See a sample build output of it failing here.