Trickle up fatal braze errors as exceptions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
- Coverage 95.93% 94.57% -1.36%
==========================================
Files 3 3
Lines 172 166 -6
==========================================
- Hits 165 157 -8
- Misses 7 9 +2 |
pramttl
force-pushed
the
exceptions-trickle-up
branch
from
543e5ef to
47c80c5
Compare
pramttl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed offline between @AA33 and @pramttl, trickle up exceptions. The exceptions are trickled up post retry logic.
This allows the consumer of the client to add custom behavior based on the exception.