Skip to content
This repository has been archived by the owner on Oct 4, 2019. It is now read-only.

chain_properties_19 #295 #938

Merged
merged 1 commit into from
Aug 23, 2018
Merged

chain_properties_19 #295 #938

merged 1 commit into from
Aug 23, 2018

Conversation

maslenitsa93
Copy link

@maslenitsa93 maslenitsa93 commented Aug 22, 2018

#295

Checklists

Testing chain_properties_19

Use testnet.

  1. Execute following HTML in browser:
<script src="node_modules/golos-js/dist/golos.min.js"></script>
Hello world
<script>
golos.config.set('websocket', 'ws://127.0.0.1:8091');
golos.api.getChainProperties(function (err, result) {
document.body.innerHTML += '<pre>' + JSON.stringify(result, null, 2) + "</pre>";
});
</script>

Response:

  ...
  "max_referral_interest_rate": 1000,
  "max_referral_term_sec": 15552000,
  "referral_break_fee": "0.000 GOLOS"
}
  1. Execute following cli_wallet script:
./cli_wallet --server-rpc-endpoint=ws://127.0.0.1:8091
set_password qwer
unlock qwer
import_key 5JVFFWRLwz6JoP9kguuRFfytToGU6cLgBVTL9t6NB3D3BQLbUBS
info

Response:

  ...
  "max_referral_interest_rate": 1000,
  "max_referral_term_sec": 15552000,
  "referral_break_fee": "0.000 GOLOS"
}
  1. Next, execute following in cli_wallet:
update_chain_properties "cyberfounder" {"account_creation_fee": "1.000 GOLOS", "create_account_min_golos_fee": "1.000 GOLOS", "create_account_min_delegation": "1.000 GOLOS",  "create_account_delegation_time": 86400, "min_delegation": "1.000 GOLOS", "max_referral_interest_rate": 500, "max_referral_term_sec": 10552000, "referral_break_fee": "20.000 GOLOS"} true

Result: fail, because referral_break_fee should be between 1account_creation_fee and 10account_creation_fee.

Try this:

update_chain_properties "cyberfounder" {"account_creation_fee": "1.000 GOLOS", "create_account_min_golos_fee": "1.000 GOLOS", "create_account_min_delegation": "1.000 GOLOS",  "create_account_delegation_time": 86400, "min_delegation": "1.000 GOLOS", "max_referral_interest_rate": 500, "max_referral_term_sec": 10552000, "referral_break_fee": "0.000 GOLOS"} true

Result: same fail again.

Finayll, try this:

update_chain_properties "cyberfounder" {"account_creation_fee": "1.000 GOLOS", "create_account_min_golos_fee": "1.000 GOLOS", "create_account_min_delegation": "1.000 GOLOS",  "create_account_delegation_time": 86400, "min_delegation": "1.000 GOLOS", "max_referral_interest_rate": 500, "max_referral_term_sec": 10552000, "referral_break_fee": "10.000 GOLOS"} true

Result: it runs successful. Refresh webpage in browser. Response:

  ...
  "max_referral_interest_rate": 500,
  "max_referral_term_sec": 10552000,
  "referral_break_multiplier": "10.000 GOLOS"
}

@maslenitsa93 maslenitsa93 added this to the 0.19.0 milestone Aug 22, 2018
@maslenitsa93 maslenitsa93 self-assigned this Aug 22, 2018
@maslenitsa93 maslenitsa93 force-pushed the 295-referral-program branch 2 times, most recently from f264f7f to 6e64bf0 Compare August 22, 2018 07:43
@maslenitsa93 maslenitsa93 requested a review from afalaleev August 22, 2018 09:47
@maslenitsa93 maslenitsa93 changed the title Referral program #295 chain_properties_19 #295 Aug 22, 2018
@maslenitsa93
Copy link
Author

Autotests passed.

@afalaleev
Copy link
Member

Please rebase to one commit.

@maslenitsa93
Copy link
Author

Tested on testnet

@afalaleev afalaleev merged commit dda652f into golos-v0.19.0 Aug 23, 2018
@afalaleev afalaleev deleted the 295-referral-program branch August 23, 2018 04:28
AKorpusenko added a commit that referenced this pull request Sep 18, 2018
…eward poll. #898

Merge pull request #937 from GolosChain/golos-v0.18.4

Golos v0.18.4
Add chain_properties_19 #295

Merge pull request #938 from GolosChain/295-referral-program

chain_properties_19 #295
Made auction window votable. Fixed rewards calculations. #898

Merge branch 'master' into golos-v0.19.0

Fix naming in chain_properties_19 #295

Merge pull request #939 from GolosChain/295-chain-propertie

Fix naming in chain_properties_19 #295
Updated with current 19.0

Added auction_window_size to wallet update_chain_properties. #898

Fixed some codestyle errors. Changed auction_window_weight to uint128_t. #898

Added HF19 checks. Fixed auction_window_size in update_chain_properties. #898

Added auction_window_max_size constant to config. Added HF19 checks in steem_evaluator. #898

Fixed some comment reward logic in tests. #898

Referral program, ASSERT_REQ_HF improved, HF 19 #295

Merge pull request #942 from GolosChain/295-referral-program-impl2

Referral program implemented #295
Update with current 19.0. #898

Fixed auction window tokens return to reward fund. #898

Renamed modify reward fund function. #898
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants