This repository has been archived by the owner on Oct 4, 2019. It is now read-only.
Remove min curation percent for witnesses #1009 #1278
Closed
+19
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afalaleev
suggested changes
Apr 7, 2019
| GOLOS_CHECK_VALUE(STEEMIT_MIN_CURATION_PERCENT_PRE_HF21 <= percent && percent <= STEEMIT_MAX_CURATION_PERCENT, | ||
| "Curation rewards percent must be between ${min} and ${max}.", | ||
| ("min", STEEMIT_MIN_CURATION_PERCENT)("max", STEEMIT_MAX_CURATION_PERCENT)); | ||
| } |
There was a problem hiding this comment.
This checking shouldn't happen.
The checking of mprops should work.
There was a problem hiding this comment.
@afalaleev Look at this checking:
https://github.com/GolosChain/golos/blob/1009-min-curation-percent-remove-witness-limit/libraries/protocol/steem_operations.cpp#L170
In pre-HF21 it was:
25% <= percent
And it was failing independent from mprops.
And it will continue failing on these nodes with old version.
In new nodes it should fail, too, if no HF21.
About default value you are right.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1009