-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use build_profile to improve build times #149
Conversation
What's the process / script command for building
Is there a blocker for merging godotengine/godot-cpp#1167? |
The
There's certainly more that could be done with it, but I personally think it's helpful enough as-is to merge and improve later. Fabio has it marked as a draft still, though - I pinged him on a comment there asking what he thinks still needs to be done. |
The script could be automatically invoked via a scons argument. For example, the |
Because it's parsing the It'd be theoretically possible to figure out the dependencies between the engine classes from the |
d2b2454
to
55338d7
Compare
I just updated this PR for the latest changes from Fabio on PR godotengine/godot-cpp#1167
In the recent changes, Fabio made it a little smarter, which allowed me to remove the |
55338d7
to
8ed3aeb
Compare
Now that PR #171 has been merged and the |
Since I've been working on CI this week, the fact that this repo builds painfully slow on GitHub Actions was starting to get to me :-)
This PR uses godot-cpp PR godotengine/godot-cpp#1167 to only build the classes that are actually used. Unfortunately, because we make an editor plugin and load GLTF's, we do actually use quite a few classes. However, this still seems to cut build times by 2-4x!
Marking as a draft for now, because I'm not sure if this is the right way to integrate it. Currently, I'm including a patch for godot-cpp, and while the
build_profile.json
is built via a script, it's committed to the repo.