Consistently capitalise budget menu entries #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no display option but the file indicated that there might be so created one and added the plot size to it.
Change account-piecharts.scm to use the modified htm-piechart.scm that now can use plot size percentages.
An option had changed in the transaction report that this one uses.
Change price-scatter.scm to use new html-scatter.scm for new plot size
There is a requirement to delete the "Fancy Date Format" book KVP data when set to unset. This was not possible as is as it would delete all the 'Business' options. This is still possible by passing a null list.
When the format is set to unset, the kvp data will now be removed and added a function to retrieve the 'Fancy Date Format' and test for it being valid, if not retrieve the preference date format.
Use the new function so we do not need to test for valid format
There are errors when closing the application to do with gnc_uri when trying to create a filename from an empty book_id value to update the page title. Added a test for empty book_id as well as it being null.
It makes the jqplot charts behave poorly. And looking at current websites on the net, most don't specify this header any more.
Because I keep forgetting them...
And test out-of-range values in other functions for good measure.
This enables a number of additional unit tests. Unfortunately several of them fail on travis and need some more attention.
This is an alias for master, so it would only duplicate that test run.
Both forms apparently work on more recent compilers
This is needed if there is a mix of entries with tax included and excluded
taxinvoice was throwing an exception when there were taxes on bill entries. It also did scan the invoice parts to determine if there were taxes and discounts.
Got it all wrong before. Don’t use to complex expressions!
'uint' is a non-standard typedef not supported by MinGW.
Note that Boost::regex and Boost::locale must also be built with ICU support.
This fixup was accidentally merged in another private branch of mine rather than in the previous commit...
If a file is opened from the history list and does not exist the dialog advises of this and asks if it should be removed from the list. If a file is opened from the command line and does not exist, the normal dialog is used
At the same time require --std=gnu11 instead of --sdt=gnu99. This allows us to drop some conditionals is several places. I've chosen 2.4 as that is the version available in travis, which appears to be the oldest platform care about. Debian stable has 2.46 in backports, our windows environment has 2.42
The query runs from 00:00:00 on the start date to 23:59:59 on the end date, effectively one day more than the number specified.
The symptom was that in 2017 the PDT->PST transition was set a week late. The cause was that the timezone lookup function went the wrong way, finding the *next* timezone rule instead of the desired one because timezone rules are stored for the year that they start rather than when they end. Fix reverses the search to find the correct timezone rule. Commit includes new tests to detect the problem.
simonhollingshead
changed the title
simonhollingshead
changed the title
|
Messed up trying to fix this to point at maint not master. Am going to just replace the whole PR to avoid a world of hurt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the last few months, I've had a minor frustration over the fact the menu items in my en-GB variant of Gnucash's "Actions" > "Budget" are:
So this pull request makes all instances of 'Budget' capitalised.