Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports too much empty space #228

Merged

Conversation

pnemonic78
Copy link
Collaborator

No description provided.

@pnemonic78 pnemonic78 added the enhancement New feature or request label Jan 2, 2025
@pnemonic78 pnemonic78 self-assigned this Jan 2, 2025
Copy link

@djbrown djbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM

screenshots (before/after) would be nice on ui-relevant PRs and issues

protected void onPostExecute(Void result) {
BaseDrawerActivity activity = mReportsActivity;
if (activity != null) {
// FIXME display the result data that was generated.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pnemonic78 is there another bug here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually more of a TODO

@pnemonic78 pnemonic78 merged commit 02a4f56 into GnuCash-Pocket:master Jan 5, 2025
5 checks passed
@pnemonic78 pnemonic78 deleted the feature/reports_empty_space branch January 5, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants