Adds comma_first as an option for javascript #2569
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because after digging thru js-beautify's code:
```atom-beautify/node-modules/js-beautify/js/lib/beautifier.js ```
on approximately line 1213 inside the Beautifier.prototype.handle_comma function, you can see on line 1227:
```
} else if (this._options.comma_first){ // <--------
```
so the option "comma_first" both exists, and is usable and works as expected if you specify the option in your .jsbeautifyrc
:-)
|
i think the appveyor thing has nothing to do with this. i just updated readmes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because after digging thru js-beautify's code:
atom-beautify/node-modules/js-beautify/js/lib/beautifier.json approximately line 1213 inside the Beautifier.prototype.handle_comma function, you can see on line 1227:
so the option "comma_first" both exists, and is usable and works as expected if you specify the option in your .jsbeautifyrc
:-)
What does this implement/fix? Explain your changes.
js-beautify has an option for comma first style. it exists in their code. i just added to the readme so people know it exists
Does this close any currently open issues?
had i made one rather than solving the problem directly, yeah
Any other comments?
ezpz. relates to my other pull request which just adds the example to the options.md
Checklist
Check all those that are applicable and complete.
masterbranchnpm run docsCHANGELOG.mdunder "Next" section