-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Notices on transactions #2443
Conversation
crates/glaredb/src/local.rs
Outdated
// messages interspersed with the output would be | ||
// annoying. | ||
for notice in self.sess.drain_notices() { | ||
println!( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to write to stderr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could. Since this is in the interactive portion, I don't know that it matters. But we could also move this to the execute
func and eprintln there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stderr feels right for this kind of thing, (if only because it makes it easier to write scripts.) but this doesn't need to block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Emit notices on transaction commands warning about our incomplete transaction support.
psql:
CLI (colorful):
Some pg protocol tests added to assert the notices.