chore: Remove temp catalog, session vars (mostly) from remote session #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goal: Try to make the remote session as stateless as possible to allow for it to execute any plan for a specific database. There's still some need for `SessionVars` when creating the datafusion runtime/context, but I just used the default for now. It's likely that we'll just be provided a well-typed struct for session configuration soonish.
tychoish
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to distributed execution.
Goal: Try to make the remote session as stateless as possible to allow for it to execute any plan for a specific database.
There's still some need for
SessionVarswhen creating the datafusion runtime/context, but I just used the default for now. It's likely that we'll just be provided a well-typed struct for session configuration soonish.