Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add node/npm engines in package.json #978

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #978 (125a389) into master (050c589) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #978   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files         483      483           
  Lines        6405     6405           
=======================================
  Hits         6051     6051           
  Misses        354      354           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 050c589...125a389. Read the comment docs.

@VonOx
Copy link
Contributor

VonOx commented Nov 25, 2020

Not sure if this help because no warning is produce and user can run anything ( Maybe I'm wrong ? )

@cicoub13
Copy link
Contributor Author

cicoub13 commented Nov 26, 2020

Not sure if this help because no warning is produce and user can run anything ( Maybe I'm wrong ? )

You're right, no warning but developers can now easily which version of node/npm to use. If you think documentation (https://gladysassistant.com/fr/docs/api/setup-development-environnement) is enough, I'll close this PR.

There is one way to force node version, it's by adding a preinstall script in package.json that checks version. But I find it too restrictive.

@VonOx
Copy link
Contributor

VonOx commented Nov 26, 2020

You're right, no warning but developers can now easily wich version of node/npm to use. If you think documentation (https://gladysassistant.com/fr/docs/api/setup-development-environnement) is enough, I'll close this PR.

No , I'm just asking ;)

I find it too restrictive.

I agree

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@Pierre-Gilles Pierre-Gilles merged commit ec698c3 into GladysAssistant:master Nov 27, 2020
@Pierre-Gilles
Copy link
Contributor

@all-contributors please add @cicoub13 for code

@allcontributors
Copy link
Contributor

@Pierre-Gilles

I've put up a pull request to add @cicoub13! 🎉

R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
@cicoub13 cicoub13 deleted the chore-node-engines branch May 15, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants