-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add node/npm engines in package.json #978
chore: Add node/npm engines in package.json #978
Conversation
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 483 483
Lines 6405 6405
=======================================
Hits 6051 6051
Misses 354 354 Continue to review full report at Codecov.
|
Not sure if this help because no warning is produce and user can run anything ( Maybe I'm wrong ? ) |
You're right, no warning but developers can now easily which version of node/npm to use. If you think documentation (https://gladysassistant.com/fr/docs/api/setup-development-environnement) is enough, I'll close this PR. There is one way to force node version, it's by adding a |
No , I'm just asking ;)
I agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
@all-contributors please add @cicoub13 for code |
I've put up a pull request to add @cicoub13! 🎉 |
https://docs.npmjs.com/cli/v6/configuring-npm/package-json
After discussion https://community.gladysassistant.com/t/fresh-development-installation/5785