-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle caldav color for calendars #899
Handle caldav color for calendars #899
Conversation
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 494 494
Lines 6552 6552
=======================================
Hits 6202 6202
Misses 350 350
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When starting the frontend locally with a DB with existing event, I got the following crash in the UI:
Uncaught (in promise) TypeError: Cannot read property 'substring' of null
at isBright (color.js?d8c9:2)
at Map._this.eventPropGetter (index.js?3b01:39)
at Object.eventProp (react-big-calendar.esm.js?496b:4411)
at EventCell.render (react-big-calendar.esm.js?496b:268)
at N (preact.js?10a9:1)
at eval (preact.js?10a9:1)
at k (preact.js?10a9:1)
at g (preact.js?10a9:1)
at T (preact.js?10a9:1)
at N (preact.js?10a9:1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, it works fine!
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
To synchronize color of the calendar inside CalDAV service.
julienL post: https://community.gladysassistant.com/t/calendrier-module-caldav/4598/58
Tested with Nexctloud, iCloud, Google Calendar