Improve integrations tab UI Fixes #720 #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrovato
force-pushed
the
atrovato/issue720
branch
from
ee39652 to
ca5ec86
Compare
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
=======================================
Coverage 92.40% 92.40%
=======================================
Files 419 419
Lines 5426 5426
=======================================
Hits 5014 5014
Misses 412 412
Continue to review full report at Codecov.
|
atrovato
changed the title
Pierre-Gilles
approved these changes
May 18, 2020
jmellano
added a commit
to jmellano/Gladys
that referenced
this pull request
May 28, 2020
jmellano
added a commit
to jmellano/Gladys
that referenced
this pull request
Jun 2, 2020
Pierre-Gilles
added a commit
that referenced
this pull request
Jul 28, 2020
* feat(openweather): implementation to API openweather TODO : Have a decision about DarkSky (keep it and enable weather with 2 services) or remove it * feat(openweather): remove darksky integration * feat(openweather): add unit test * feat(openweather): solve merge conflicts * fix: review comment * Improve integrations tab UI (#805) -> merge report * fix: review comments "si", 'si' -> 'metric' * Fix weather key in front Co-authored-by: Julien Mellano <julien.spam82@gmail.com>
NickDub-old
pushed a commit
to NickDub/Gladys
that referenced
this pull request
Aug 7, 2020
Fixes GladysAssistant#720 Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
NickDub-old
pushed a commit
to NickDub/Gladys
that referenced
this pull request
Aug 7, 2020
…ation (GladysAssistant#837) * feat(openweather): implementation to API openweather TODO : Have a decision about DarkSky (keep it and enable weather with 2 services) or remove it * feat(openweather): remove darksky integration * feat(openweather): add unit test * feat(openweather): solve merge conflicts * fix: review comment * Improve integrations tab UI (GladysAssistant#805) -> merge report * fix: review comments "si", 'si' -> 'metric' * Fix weather key in front Co-authored-by: Julien Mellano <julien.spam82@gmail.com>
R6n0
pushed a commit
to R6n0/Gladys
that referenced
this pull request
Dec 2, 2020
Fixes GladysAssistant#720 Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
R6n0
pushed a commit
to R6n0/Gladys
that referenced
this pull request
Dec 2, 2020
…ation (GladysAssistant#837) * feat(openweather): implementation to API openweather TODO : Have a decision about DarkSky (keep it and enable weather with 2 services) or remove it * feat(openweather): remove darksky integration * feat(openweather): add unit test * feat(openweather): solve merge conflicts * fix: review comment * Improve integrations tab UI (GladysAssistant#805) -> merge report * fix: review comments "si", 'si' -> 'metric' * Fix weather key in front Co-authored-by: Julien Mellano <julien.spam82@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm teston both front/server)npm run eslinton both front/server)npm run prettieron both front/server)npm run compare-translationson front)[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.[ ] Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Adding "All integrations" menu + move title and description to i18n files.