Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scene execution concurrency, fix camera issues & fix MQTT new value parsing #769

Merged
merged 7 commits into from
May 4, 2020

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented May 4, 2020

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #769 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
+ Coverage   92.36%   92.38%   +0.02%     
==========================================
  Files         419      419              
  Lines        5419     5422       +3     
==========================================
+ Hits         5005     5009       +4     
+ Misses        414      413       -1     
Flag Coverage Δ
#server 92.38% <100.00%> (+0.02%) ⬆️
Impacted Files Coverage Δ
server/lib/scene/index.js 100.00% <ø> (ø)
...r/services/mqtt/lib/handler/handleGladysMessage.js 100.00% <ø> (ø)
server/lib/index.js 94.20% <100.00%> (ø)
server/lib/system/index.js 100.00% <100.00%> (ø)
server/lib/system/system.init.js 100.00% <100.00%> (ø)
server/services/rtsp-camera/index.js 90.90% <100.00%> (+13.13%) ⬆️
server/services/rtsp-camera/lib/getImage.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 947ad9b...1166164. Read the comment docs.

@Pierre-Gilles Pierre-Gilles changed the title Remove scene execution concurrency Remove scene execution concurrency & fix camera issues May 4, 2020
@Pierre-Gilles Pierre-Gilles changed the title Remove scene execution concurrency & fix camera issues Remove scene execution concurrency, fix camera issues & fix MQTT new value parsing May 4, 2020
@Pierre-Gilles Pierre-Gilles merged commit ca3fc7f into master May 4, 2020
@Pierre-Gilles Pierre-Gilles deleted the multiple-bug-fixes branch May 4, 2020 14:01
NickDub-old pushed a commit to NickDub/Gladys that referenced this pull request Aug 7, 2020
…value parsing (GladysAssistant#769)

* Remove scene queue concurrency

* Fix GladysAssistant#749 : Camera should not create tons of folders + improve image compression

* Fix camera tests

* Fix scene UI, automatically add actions blocks

* Add tests to cameraService.start

* Fix GladysAssistant#767: MQTT service should parseFloat received device value

* Fix MQTT tests
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
…value parsing (GladysAssistant#769)

* Remove scene queue concurrency

* Fix GladysAssistant#749 : Camera should not create tons of folders + improve image compression

* Fix camera tests

* Fix scene UI, automatically add actions blocks

* Add tests to cameraService.start

* Fix GladysAssistant#767: MQTT service should parseFloat received device value

* Fix MQTT tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant