Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactor Chart.jsx to improve readability and maintainability #2126

Merged

Conversation

Terdious
Copy link
Contributor

@Terdious Terdious commented Oct 7, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix: changing names of features other than on binary charts is not taken into account
https://community.gladysassistant.com/t/gladys-assistant-4-46-les-tableaux-de-bords/9112/3?u=terdious
https://community.gladysassistant.com/t/gladys-assistant-4-46-les-tableaux-de-bords/9112/5?u=terdious

@Terdious Terdious requested a review from Pierre-Gilles October 7, 2024 10:19
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (2b8e274) to head (e9e2d4d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2126   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         867      867           
  Lines       14187    14187           
=======================================
  Hits        13972    13972           
  Misses        215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Oct 7, 2024

#2760 Bundle Size — 10.24MiB (~+0.01%).

e9e2d4d(current) vs 2b8e274 master#2753(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2760
     Baseline
#2753
Regression  Initial JS 5.54MiB(~+0.01%) 5.54MiB
No change  Initial CSS 304.63KiB 304.63KiB
Change  Cache Invalidation 54.02% 0%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1492 1492
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2760
     Baseline
#2753
Regression  JS 7.32MiB (~+0.01%) 7.32MiB
No change  IMG 2.48MiB 2.48MiB
No change  CSS 321.42KiB 321.42KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch Terdious:fixed-no-custom-display...Project dashboard


Generated by RelativeCIDocumentationReport issue

@Terdious Terdious changed the title chore: Refactor Chart.jsx to improve readability and maintainability fix: Refactor Chart.jsx to improve readability and maintainability Oct 7, 2024
@Pierre-Gilles Pierre-Gilles merged commit 7b512fb into GladysAssistant:master Oct 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants