Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix volume feature #2050

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

William-De71
Copy link
Contributor

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

change the name of siren volume feature due to a problem of displaying tv and music volume

without the fix:
image

with the fix:
image

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (bcdc5ee) to head (13f4ca4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2050   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         844      844           
  Lines       13753    13753           
=======================================
  Hits        13531    13531           
  Misses        222      222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Apr 10, 2024

Job #2461: Bundle Size — 10.04MiB (~+0.01%).

13f4ca4(current) vs bcdc5ee master#2455(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #2461
     Baseline
Job #2455
Regression  Initial JS 5.38MiB(~+0.01%) 5.38MiB
No change  Initial CSS 303.21KiB 303.21KiB
Change  Cache Invalidation 53.44% 0%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1459 1459
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.78% 0.78%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #2461
     Baseline
Job #2455
Regression  JS 7.14MiB (~+0.01%) 7.14MiB
Not changed  IMG 2.46MiB 2.46MiB
Not changed  CSS 319.71KiB 319.71KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 17.53KiB 17.53KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2461 reportView William-De71:volume-fix branch activityView project dashboard

@Pierre-Gilles Pierre-Gilles merged commit 80539f1 into GladysAssistant:master Apr 15, 2024
9 checks passed
@William-De71 William-De71 deleted the volume-fix branch April 15, 2024 20:52
William-De71 added a commit to William-De71/Gladys that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants